Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
431f76b to
723f91c
Compare
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Closes #24447 as well. |
43bc77a to
efae255
Compare
|
Force-updated from current dev with hybrid TaskTool empty-output handling. Latest non-empty text still returns, legitimate tool-call/tool-only child runs return a diagnostic, and truly silent empty outputs still fail so fallback can catch them. Local verification: bun test test/tool/task.test.ts; bun typecheck from packages/opencode. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #29054
Closes #24447
Type of change
What does this PR do?
Hardens
TaskToolserialization when a child task result has no usable text output:finish === "tool-calls"or tool parts present), so successful tool work is not misclassified as a failed task.How did you verify your code works?
Tested locally with text-output, tool-call/tool-only, and truly silent child task results:
bun test test/tool/task.test.tsbun typecheckfrompackages/opencodeScreenshots / recordings
N/A, no UI change.
Checklist