Repository navigation
fix(provider): strip Nvidia Kimi tool schemas - #28997
VIVAAN-DHAWAN wants to merge 1 commit into
Conversation
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: #25492: This PR appears to address a similar issue with Kimi/Moonshot models and JSON schema handling. While the current PR (28997) specifically targets Nvidia-hosted Kimi models with a schema stripping approach, PR #25492 may have tackled a related schema depth limitation for the same provider. You should verify whether #25492 is still open or merged, and if there's any overlap in scope or approach. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #26662
Type of change
What does this PR do?
Nvidia-hosted Kimi K2.6 rejects normal tool parameter schemas with an internal server error: unhashable type: dict.
This keeps the existing Moonshot/Kimi handling, and adds the same practical fallback for Nvidia Kimi: send a minimal object schema for tool parameters. That avoids the provider-side schema hashing crash while still allowing tools to be offered.
How did you verify your code works?
From packages/opencode:
From the repo root:
I also checked the related open PR #25492. That PR is about Moonshot schema depth, while this one is scoped to the Nvidia-hosted Kimi provider error.
Screenshots / recordings
Not a UI change.
Checklist