Skip to content

fix(storage): write json files atomically - #28010

Closed
mturac wants to merge 1 commit into
anomalyco:devfrom
mturac:fix/27843-atomic-json-storage
Closed

mturac wants to merge 1 commit into
anomalyco:devfrom
mturac:fix/27843-atomic-json-storage

Conversation

@mturac

@mturac mturac commented May 17, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #27843

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

JSON writes now go through a same-directory temporary file and are published with rename. This keeps readers from observing partially written storage files, including session_diff/*.json, while preserving the existing storage locks and directory creation behavior.

How did you verify your code works?

  • bun test test/filesystem/filesystem.test.ts --timeout 30000
  • bun typecheck from packages/core
  • bun typecheck from packages/opencode
  • bun turbo typecheck
  • bunx prettier --check packages/core/src/filesystem.ts packages/opencode/test/filesystem/filesystem.test.ts
  • git diff --check

Screenshots / recordings

Not applicable; this is a storage write-path fix covered by filesystem tests.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

session_diff read/write race can trigger Unexpected EOF and local server exit

1 participant