Skip to content

fix(desktop): await execFilePromise and read stdout properly - #27499

Merged
Brendonovich merged 1 commit into
devfrom
fix/windows-app-path-promise
May 14, 2026
Merged

Brendonovich merged 1 commit into
devfrom
fix/windows-app-path-promise

Conversation

@Brendonovich

Copy link
Copy Markdown
Member

Summary

Fixes a bug in resolveWindowsAppPath where execFilePromise was not being awaited correctly. The function returns a Promise that resolves to an object with a stdout property, but the code was treating it as if it returned a string directly.

Changes

  • Added await to properly wait for the promise to resolve
  • Changed from .toString() on the promise to .then((r) => r.stdout.toString()) to correctly access the stdout output

This fixes the Windows app path resolution functionality.

@Brendonovich
Brendonovich merged commit f8c3f56 into dev May 14, 2026
10 checks passed
@Brendonovich
Brendonovich deleted the fix/windows-app-path-promise branch May 14, 2026 09:52
@agamotto

agamotto commented May 15, 2026 •

Copy link
Copy Markdown

@adamdotdevin @Brendonovich

Zed/VSCode now launchs without error. However:

  1. Button gets stuck with a loading animation until the launched app is closed - this effectively prevents us from launching another app
  2. Powershell is still not working. The target path is incorrectly passed:

powershell.exe C:\TEMP
C:\TEMP : The term 'C:\TEMP' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a
path was included, verify that the path is correct and try again.

Correct syntax:

powershell.exe -NoExit -Command "Set-Location 'C:\TEMP'"

AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
isaacfinnegan pushed a commit to isaacfinnegan/whispercode that referenced this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants