Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the BasicTool component’s defer behavior so that default-open deferred tools no longer mount their (potentially heavy) children during the initial session render. Instead, initial deferred tool bodies begin mounting after first paint, then mount FIFO, one per animation frame, preserving open state and eventual rendered output while improving initial render performance.
Changes:
- Introduce a global deferred-mount queue and RAF-driven flush to progressively mount default-open deferred tool bodies after first paint.
- Change initial
readystate sodefaultOpen+deferstarts closed-over-body (ready=false) until scheduled. - Refactor “ready” scheduling/cancellation logic and add an
onMounthook to start the initial deferred mounting process.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasicTool deferapply to default-open tools instead of mounting heavy children during session render.Verification
bun typecheckfrompackages/uibun typecheckfrompackages/appbun turbo typecheckbun bench:dribblefromopencode-desktop-perfPerf Notes
Risk
deferprop intent and does not change open state or diff rendering.