Repository navigation
Conversation
In v1.14.41, resolveWindowsAppPath was refactored from sync to async
but execFilePromise('where', [appName]).toString() was called without
await, returning the string '[object Promise]' instead of the actual
resolved path. This caused app resolution to always fail on Windows.
Added a test that verifies the fix with a mocked execFile.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Closed
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In v1.14.41, resolveWindowsAppPath was refactored from sync to async but execFilePromise("where", [appName]).toString() was called without await. This returned "[object Promise]" instead of the resolved path, breaking app resolution (resolveAppPath) on Windows.
Root Cause
packages/desktop/src/main/apps.ts:61 —
execFilePromise("where", [appName]).toString()execFilePromise (util.promisify(execFile)) returns a Promise. Calling .toString() before await yields "[object Promise]", so path parsing receives garbage.
Fix
Verification
bun test packages/desktop/src/main/apps.test.ts — 1 pass, 0 fail
Related
Issue #26278 reporter also observed sidecar exiting with code 0 seconds after Windows startup in v1.14.41. That symptom may be separate (utilityProcess.fork sidecar refactor) but this fixes a definite bug in the same release.
Commit authored as "OpenCode Contributor".