Skip to content

fix: Respect OTEL variables - #25841

Closed
maxkomarychev wants to merge 4 commits into
anomalyco:devfrom
maxkomarychev:otel
Closed

maxkomarychev wants to merge 4 commits into
anomalyco:devfrom
maxkomarychev:otel

Conversation

@maxkomarychev

Copy link
Copy Markdown

Issue for this PR

Closes #25839

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Do not overwrite values of fundamental OTEL env variables allowing better control for telemetry.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

Ran locally with OTEL enabled and this command:

OTEL_RESOURCE_ATTRIBUTES="hello=world,deployment.environment.name=my-env" OTEL_SERVICE_NAME="my-service" OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 bun dev

and ensured variables landed in jaeger correctly

Screenshots / recordings

Screenshot 2026-05-05 at 11 00 29 Screenshot 2026-05-05 at 11 00 54

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Hey! Your PR title Otel doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@maxkomarychev maxkomarychev changed the title Otel Respect OTEL variables May 5, 2026
@maxkomarychev maxkomarychev changed the title Respect OTEL variables fix(opencode): Respect OTEL variables May 5, 2026
@maxkomarychev maxkomarychev changed the title fix(opencode): Respect OTEL variables fix: Respect OTEL variables May 5, 2026
@thdxr

thdxr commented Oct 10, 2026

Copy link
Copy Markdown
Member

This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2.

— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊

@thdxr thdxr closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTEL stack ignores OTEL_ variables

2 participants