Repository navigation
fix: show MCP tool arguments in permission dialog - #24605
Closed
rachadaccoumeh wants to merge 2 commits into
Closed
rachadaccoumeh wants to merge 2 commits into
rachadaccoumeh wants to merge 2 commits into
Conversation
- Backend: pass tool args in metadata when asking for MCP tool permissions - Frontend: display tool arguments in permission dock UI
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MCP tool permission dialog showing only
*instead of actual tool arguments, making it hard for users to understand what command will be executed before approving.Problem
When using MCP tools, the permission approval dialog shows only
*instead of the actual arguments.Solution
Testing
Use any MCP tool and trigger a permission dialog - arguments should now be visible.