Repository navigation
fix: replace catch (e: any) with proper unknown handling in mcp/index.ts - #24503
Closed
alfredocristofano wants to merge 2 commits into
Closed
alfredocristofano wants to merge 2 commits into
alfredocristofano wants to merge 2 commits into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
4 tasks done
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Closing this one myself. The branch picked up a large unrelated diff and now shows conflicts, so it is not useful for review in its current form. I’ll keep the issue open for a cleaner fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24327
Type of change
What does this PR do?
Replaces two instances of
catch: (e: any)with properunknownerror handling insrc/mcp/index.ts.fetchFromClient(line 169):e: any→ewithe instanceof ErrorguardwithClient(line 692):e: any→ewithe instanceof ErrorguardThe project style guide explicitly prohibits
any("Avoidany; prefer precise types"). Thee: anyannotation disables type checking and can cause runtime crashes if the caught value is not anError(e.g.null,undefined, or a plain string). Both sites accessed.messagedirectly, which would throw at runtime for non-Error values.How did you verify your code works?
e instanceof Error ? e.message : String(e)for safe message extractione instanceof Error ? e : new Error(String(e))to preserve the Error contract expected by Effect.tryPromiseChecklist