Skip to content

fix: add logging to silent catch block in workspace restore bootstrap - #24502

Closed
alfredocristofano wants to merge 2 commits into
anomalyco:devfrom
alfredocristofano:contrib/cristofano
Closed

fix: add logging to silent catch block in workspace restore bootstrap#24502
alfredocristofano wants to merge 2 commits into
anomalyco:devfrom
alfredocristofano:contrib/cristofano

Conversation

@alfredocristofano

@alfredocristofano alfredocristofano commented Apr 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #24327

Type of change

  • Bug fix

What does this PR do?

Adds a log.warn() call to a previously silent catch {} block in dialog-workspace-create.tsx:146.

The input.sync.bootstrap({ fatal: false }) call could fail silently during workspace session restore, making it impossible to diagnose bootstrap failures from logs.

How did you verify your code works?

  • Confirmed the file already imports errorData and log is available in scope
  • The change is a single-line addition of structured logging, matching existing patterns in the same file (line 149)
  • No tests needed: this is a logging-only change with no behavioral side effects

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR
  • I have read the CONTRIBUTING.md guidelines

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Apr 26, 2026
@alfredocristofano alfredocristofano mentioned this pull request Apr 26, 2026
Closed
@github-actions

github-actions Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found:

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Apr 26, 2026
@github-actions

github-actions Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@alfredocristofano

alfredocristofano commented Apr 27, 2026

Copy link
Copy Markdown
Author

Closing this one myself. The branch picked up a large unrelated diff and now shows conflicts, so it is not useful for review in its current form. I’ll keep the issue open for a cleaner fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] ~30 catch blocks silently swallow errors across core modules

1 participant

@alfredocristofano