Repository navigation
Conversation
Strip additionalProperties: false from tool/input JSON schemas when targeting xAI models via OpenRouter. xAI rejects this keyword while their validator already defaults to false. Fixes anomalyco#23704
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potential duplicate:
This PR has the exact same title as the current PR (#23707) and appears to address the same issue - sanitizing xAI tool schemas for OpenRouter by removing You may want to check if PR #23706 is already merged or under review, and coordinate with it if needed. |
3 of 6 tasks
Author
|
Closing, using the other one (double added via GH API), reference this one instead: #23707 |
dotCipher
changed the title
dotCipher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23704
Type of change
What does this PR do?
Tool calling fails for xAI models (e.g.
grok-4.1-fast) when used through OpenRouter or the nativexaiprovider. The error is:xAI structured output docs state:
additionalPropertiesdefaults tofalsealreadyfalseare rejectedSo the fix strips
additionalProperties: falsefrom tool/input JSON schemas before sending to xAI. This preserves the intended strictness (since false is the default) while avoiding the validator rejection.The change is scoped to:
providerID === "xai"(native xAI provider)providerID === "openrouter"withmodel.api.id.startsWith("x-ai/")(xAI models via OpenRouter)Non-xAI models are unaffected.
How did you verify your code works?
Added unit tests in
packages/opencode/test/provider/transform.test.ts:additionalProperties: falsefor both OpenRouter xAI and native xai providertrueadditionalPropertiesare preservedLocal verification pending (installing bun to run
bun testand E2E test againstopenrouter/x-ai/grok-4.1-fast).Screenshots / recordings
N/A — no UI changes.
Checklist