Repository navigation
fix(observability): handle OTEL headers with '=' in value - #22564
Merged
Merged
Conversation
The OTEL headers parser now correctly handles header values that contain '=' characters. Previously, splitting on '=' would truncate values containing '=', breaking auth tokens and other headers that use '=' within their values.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This was referenced Apr 17, 2026
cmaloney111
pushed a commit
to psi-oss/gpd-app
that referenced
this pull request
Apr 20, 2026
…22564) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…22564) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
isaacfinnegan
pushed a commit
to isaacfinnegan/whispercode
that referenced
this pull request
Jun 15, 2026
…22564) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OTEL headers parser now correctly handles header values that contain '=' characters.
Problem
Previously, splitting on '=' would truncate values containing '=', breaking auth tokens and other headers that use '=' within their values.
For example, a header like
Authorization=Bearer token=abc123would be parsed as:{ Authorization: "Bearer token" }(truncated){ Authorization: "Bearer token=abc123" }(correct)Changes
x.split("=")to capture only first split point