Repository navigation
fix(otlp): split OTLP headers on first = only - #22201
Closed
robertyates wants to merge 1 commit into
Closed
robertyates wants to merge 1 commit into
robertyates wants to merge 1 commit into
Conversation
`OTEL_EXPORTER_OTLP_HEADERS` values can contain `=` in the value
portion (e.g. Sentry's `x-sentry-auth=sentry sentry_key=KEY`).
The previous `x.split("=")` with array destructuring `[key, value]`
splits on every `=` and silently drops everything after the second
one, causing authentication failures.
Fix: use `indexOf("=")` + `slice` to split only on the first `=`,
preserving the full value.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22202
Type of change
What does this PR do?
The OTLP header parser in
oltp.tsusesx.split("=")with destructuring, which splits on every=in the string. When the header value itself contains=(e.g. Sentry'sx-sentry-auth=sentry sentry_key=abc123), the actual key gets silently dropped.Fixed by splitting on the first
=only viaindexOf+slice.How did you verify your code works?
Ran
opencode servewithOTEL_EXPORTER_OTLP_ENDPOINTandOTEL_EXPORTER_OTLP_HEADERSset to a Sentry OTLP endpoint. Before the fix: traces silently fail (401). After: traces land in Sentry.Screenshots / recordings
N/A — not a UI change.
Checklist