Repository navigation
Conversation
) When multiple sessions run concurrently in the same project, the shared Snapshot service's patch() returns ALL files changed since track(), including modifications from other sessions' tools. Track which files each processor's tools actually modified via tool result metadata, then filter patch.files before emitting a patch part. Also adds optional ?sessionID= query param to /event SSE endpoint for server-side event filtering.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Collaborator
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20552
Type of change
What does this PR do?
When multiple sessions run concurrently in the same project directory, the Snapshot service operates on a shared git index (scoped per-directory via InstanceState.make, not per-session). snapshot.patch(hash) returns ALL files changed since rack(), including modifications from other sessions' tools. This causes patch parts from one session to contain file paths from another session.
The fix adds per-processor file tracking: a modifiedFiles set is populated from tool result metadata during each step, then used to filter patch.files before emitting a patch part. Both the normal inish-step path and the cleanup path apply the same filter.
Tool metadata fields used:
esults[].filediff.file (multiedit tool — delegates to edit)
Files modified by �ash are not tracked since it doesn't report file paths — this is an accepted limitation matching current behavior.
Also adds an optional ?sessionID= query param to the /event SSE endpoint for server-side event filtering by session.
How did you verify your code works?
Verified by tracing the data flow:
Screenshots / recordings
N/A — core logic change, no UI changes.
Checklist