Repository navigation
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search results, I found one potentially related PR: PR #12801: feat(opencode): mcp permission patterns This PR is related because it addresses MCP permission patterns, which is the same feature area that PR #19618 is fixing. PR #12801 appears to be the original feature implementation, while PR #19618 is fixing a bug where permission prompts show |
Request MCP tool permission with the concrete tool key instead of wildcard patterns, and remove stale prompt test code that referenced an internal API no longer exported.
2d4a693 to
9e44794
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #19549
Type of change
What does this PR do?
Fixes MCP permission prompts showing
*instead of the real MCP tool name. In MCP tool execution wrapping, permission request patterns now use the concrete tool key ([key]) for bothpatternsandalwaysinstead of wildcard values.How did you verify your code works?
test/session/prompt.test.tsthat resolves tools with a mocked MCP tool and asserts the permission request uses the MCP key inpatternsandalways.bun test test/session/prompt.test.ts -t "mcp permission patterns"frompackages/opencode.bun typecheckfrompackages/opencode.Screenshots / recordings
N/A (permission request metadata fix).
Checklist