feat: add process memory telemetry and heap snapshot hooks#19494
Open
sjawhar wants to merge 3 commits intoanomalyco:devfrom
Open
feat: add process memory telemetry and heap snapshot hooks#19494sjawhar wants to merge 3 commits intoanomalyco:devfrom
sjawhar wants to merge 3 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
the
needs:compliance
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
sjawhar
force-pushed
the
feat/memory-telemetry
branch
from
e98d77a to
5975b95
Compare
- Remove SIGTERM snapshot handler (serve.ts owns shutdown) - Switch on-demand snapshots from SIGUSR2 to SIGUSR1 - Add RSS size guard (>10GB) and disk space check before snapshots - Add snapshot-in-flight guard against concurrent signals - Use Bun.gc(false) for regular sampling, Bun.gc(true) only for snapshots - Add 60s startup grace period for growth alerts - Add stderr fallback for critical telemetry events - Wire telemetry into web.ts, acp.ts, workspace-serve.ts
sjawhar
force-pushed
the
feat/memory-telemetry
branch
from
1f30205 to
c597fe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #16697
Type of change
What does this PR do?
Adds process memory telemetry and signal-triggered heap snapshot support to diagnose memory leaks and growth patterns.
Features:
This enables production diagnostics for memory issues like the 187GB RSS incident.
How did you verify your code works?
Checklist