Skip to content

fix: restore subagent footer and fix style guide violations#19491

Merged
thdxr merged 1 commit intodevfrom
fix/subagent-footer-and-style-guide
Mar 28, 2026
Merged

fix: restore subagent footer and fix style guide violations#19491
thdxr merged 1 commit intodevfrom
fix/subagent-footer-and-style-guide

Conversation

@thdxr
Copy link
Copy Markdown
Member

@thdxr thdxr commented Mar 28, 2026

Summary

This PR addresses style guide violations found in recent PRs and restores the subagent session footer that was removed in #19486.

Changes

Style Guide Fixes (PR #19488 violations)

  • dialog-model.tsx: Removed else statement in favor of early return pattern (AGENTS.md lines 84-97)
  • dialog-variant.tsx: Removed unused useSync import

Subagent Footer Restoration

  • subagent-footer.tsx: New component that displays at the bottom of subagent sessions with:
    • Session title ("Subagent session")
    • Token usage and cost information
    • Navigation controls: Parent, Prev, Next buttons with keyboard shortcuts
  • session/index.tsx: Integrated SubagentFooter to show only for sessions with parentID

Why

The subagent footer provides important navigation controls when working with subagent sessions (child sessions). Without it, users have to rely solely on keyboard shortcuts to navigate between parent and child sessions.

Testing

  • Verified subagent footer only appears in subagent sessions
  • Tested navigation buttons work correctly
  • Typecheck passes for opencode package

- Restore SubagentFooter component for subagent session navigation
- Fix else statement in dialog-model.tsx (use early return)
- Remove unused useSync import from dialog-variant.tsx
- Show subagent footer only when session has parentID
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@thdxr thdxr merged commit c3a9ec4 into dev Mar 28, 2026
11 checks passed
@thdxr thdxr deleted the fix/subagent-footer-and-style-guide branch March 28, 2026 05:46
katosun2 pushed a commit to katosun2/opencode that referenced this pull request Mar 28, 2026
Copilot AI pushed a commit to ian-morgan99/opencode that referenced this pull request Mar 28, 2026
e-n-0 pushed a commit to e-n-0/opencode that referenced this pull request Mar 29, 2026
loocor pushed a commit to loocor/opencode that referenced this pull request Mar 30, 2026
afanty2021 pushed a commit to afanty2021/opencode that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant