Skip to content

refactor(format): use ChildProcessSpawner instead of Process.spawn#19457

Merged
kitlangton merged 3 commits intodevfrom
kit/format-child-process-spawner
Mar 27, 2026
Merged

refactor(format): use ChildProcessSpawner instead of Process.spawn#19457
kitlangton merged 3 commits intodevfrom
kit/format-child-process-spawner

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • Replace Process.spawn with Effect's ChildProcessSpawner in Format service
  • formatFile now returns Effect instead of Promise, composing natively with the layer
  • Updated test to use Format.defaultLayer (self-contained, no manual platform wiring)
  • Updated effect-migration.md with full migration roadmap (tools, filesystem consolidation, primitives)

Test plan

  • bun run typecheck passes
  • CI

Replace raw Process.spawn with Effect's ChildProcessSpawner in the
Format service. formatFile now returns an Effect instead of a Promise,
composing natively with the layer.
@kitlangton kitlangton marked this pull request as ready for review March 27, 2026 21:37
@kitlangton kitlangton merged commit 5cd54ec into dev Mar 27, 2026
8 checks passed
@kitlangton kitlangton deleted the kit/format-child-process-spawner branch March 27, 2026 21:37
Copilot AI pushed a commit to ian-morgan99/opencode that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant