refactor(session): effectify Session service#19449
Merged
kitlangton merged 3 commits intodevfrom Mar 27, 2026
Merged
Conversation
Migrate Session to Effect service pattern with Bus.Service and Config.Service as layer dependencies. All methods defined as Effect.fn inside the layer, exposed through fn() facades with runPromise. - Added Session.Service, Interface, layer, defaultLayer - Bus.publish and Config.get now go through Effect services - Auto-share uses Effect.forkIn(scope) for true fire-and-forget - Extracted patch() helper for SyncEvent.Updated boilerplate - Internal methods call each other directly (not through facades) - Pure functions (getUsage, plan, isDefaultTitle) stay outside the layer
Copilot AI
pushed a commit
to ian-morgan99/opencode
that referenced
this pull request
Mar 28, 2026
Co-authored-by: ian-morgan99 <[email protected]>
loocor
pushed a commit
to loocor/opencode
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patch()helper for SyncEvent.Updated boilerplatefn()wrapper for .schema compatibility with server routesKnown inherited weaknesses (not introduced by this PR)
remove()swallows all errors via try/catch (catches defects from throw)updatePart/updatePartDeltacalled without await in prompt.ts stream handlers — timing was already fragileVerified
runPromisepreserves thrown error types (instanceof NotFoundError still works in middleware)Test plan
bun run typecheckfrom packages/opencodebun run testfrom packages/opencode (1617 pass)