Repository navigation
fix(ui): wrap fork dialog with PlatformProvider context - #18290
Protocol-zero-0 wants to merge 6 commits into
Conversation
Closes anomalyco#18250 Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Fixes a crash when invoking the “Fork” session command by ensuring the fork dialog is rendered with the required Platform context, even when dialog.show() mounts content in an isolated Solid root.
Changes:
- Import
usePlatformand capture the current platform value inuseSessionCommands. - Wrap
DialogForkwithPlatformProviderinside thesession.forkcommand’sonSelecthandler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| onSelect: () => | ||
| dialog.show(() => ( | ||
| <PlatformProvider value={platform}> | ||
| <DialogFork /> | ||
| </PlatformProvider> | ||
| )), |
There was a problem hiding this comment.
There’s currently no e2e coverage for the session.fork slash command / fork dialog path (unlike undo/redo/share). Consider adding a Playwright spec that opens the slash palette, selects session.fork, and asserts the dialog renders (and ideally that selecting an item navigates to the forked session) to prevent regressions of this context-related crash.
Follow the generated SDK signature so the fork dialog branch no longer fails typecheck on outdated auth payload keys. Made-with: Cursor
|
Follow-up update: I aligned the remaining call sites on this branch with the generated SDK signature ( instead of the old key), refreshed local dependencies, and re-ran the full repo typecheck successfully before pushing. This should clear the current typecheck failure once CI finishes rerunning. |
|
Follow-up update: I aligned the remaining auth.set call sites on this branch with the generated SDK signature, refreshed local dependencies, and re-ran the full repo typecheck successfully before pushing. CI is rerunning now, and this should clear the current typecheck failure once the new checks finish. |
Keep the runtime body payload while isolating app-side type drift so the fork dialog branch can pass typecheck across the current mixed SDK signatures. Made-with: Cursor
|
Another follow-up: I narrowed the compatibility fix to the app-side call sites only. The branch now keeps the runtime |
Refresh the branch on current dev and keep app auth context changes passing after the latest provider form updates. Made-with: Cursor
…form-context Made-with: Cursor # Conflicts: # packages/app/src/components/dialog-connect-provider.tsx # packages/app/src/pages/session/use-session-commands.tsx
|
Synced this branch with latest upstream/dev and resolved merge conflicts. Local pre-push typecheck now passes, and CI has re-run on the updated head. Happy to address any follow-up quickly. |
|
All required checks are now green on the latest synced head, and merge state is clean. This should be ready to merge when you have a moment for final review. |
|
Quick follow-up: this PR remains clean and all checks are green on the latest synced head. Should be ready to merge whenever maintainers have a merge window. |
|
Quick daily follow-up: this PR remains clean and check-green on my latest synced branch. If there is a maintainer merge window, this should be ready to land. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #18250
Type of change
What does this PR do?
Clicking the Fork button crashes with
Platform context must be used within a context providerbecausedialog.show()usescreateRoot()to render the dialog, which creates a new SolidJS root that doesn't inherit parent context providers.The fix wraps
<DialogFork />with<PlatformProvider>in the fork command'sonSelecthandler, passing the current platform value from the parent scope. This is the same pattern used elsewhere in the codebase when rendering components in isolated roots.How did you verify your code works?
dialog.show()usescreateRoot()which creates an isolated contextPlatformProvider/usePlatformfollow thecreateSimpleContextpatternChecklist
Made with Cursor