fix(app): terminal rename from context menu#18263
Merged
Brendonovich merged 6 commits intoanomalyco:devfrom Mar 22, 2026
Merged
fix(app): terminal rename from context menu#18263Brendonovich merged 6 commits intoanomalyco:devfrom
Brendonovich merged 6 commits intoanomalyco:devfrom
Conversation
Contributor
Author
|
test seems to be failing cause of upstream (not caused by this pr) |
Brendonovich
approved these changes
Mar 22, 2026
Collaborator
Brendonovich
left a comment
Brendonovich
left a comment
There was a problem hiding this comment.
kobalte will have ways to handle this more nicely in future but for now this will have to do
burn2delete
pushed a commit
to burn2delete/symbolic
that referenced
this pull request
Mar 24, 2026
Co-authored-by: Brendan Allan <[email protected]> (cherry picked from commit c529529)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18248
Type of change
What does this PR do?
Currently "rename" on from the context menu does not work
here's what roughly is going on
This PR fixes it & adds a regression test
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
First, right click on terminal, then click "Rename."
Screenshots / recordings
2026-03-19.19-32-10.mp4
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.