Repository navigation
Conversation
|
Good idea, but the wording feels too loose and ambiguous IMO. Permission system
This probably can be significantly improved, but prompt engineering is a slow process, let's keep at it. |
|
this probably should be implemented by improving the error message from a permission rejection - otherwise we need to do this for every system prompt |
|
Yup, @spoons-and-mirrors, prompting is subtle. Open to any kind of wording as long as the message is conveyed. |
|
I'm happy to go in either direction @thdxr, though it seems like there's some parts of the system prompts that should be shared by all the models, and this feels like one of them. Unless you've found that models react wildly differently to wording, in which case, it does make sense to keep them separate. This is actually related to another PR I wanted to send. In Claude Code, when you reject a tool use, the original diff (edit tool) or file content (write tool) is kept in the context, which makes it easy to reference a specific part you want to tweak. In combination with this prompt change, the UX is greatly improved IMO. If the error message (alongside the diff/content) signals that it's just the content that was rejected, then it'd work as well. |
|
maybe we can add what you have to the i also updated the error message today lmk if that works better |
Signed-off-by: jmug <[email protected]>
Signed-off-by: jmug <[email protected]>
a30212b to
bffa914
Compare
|
Moved it to the environment in system.ts @thdxr I still think that this should be part of the system prompt to protect against changes in the error message. |
f16de3d to
cc0d460
Compare
772b621 to
eb855e1
Compare
f1dc981 to
3e15a39
Compare
f8ee907 to
6a9856d
Compare
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Add disclaimer about tool use after rejection to the system prompt, makes it so the model knows it's okay to use a tool even right after it was rejected.