Repository navigation
Conversation
The project.update() endpoint accepted icon.override from the client but never stored it — the project table had no icon_override column. Custom icons survived only in the desktop app's local Tauri Store cache, which could lose the data across restarts. Add icon_override column and wire it through fromRow, update, and the fromDirectory upsert so the server round-trips the value reliably.
Author
|
seems fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #14465
Type of change
What does this PR do?
Custom project icons (uploaded via the edit-project dialog) are lost after restarting the desktop app. The
project.update()endpoint receivesicon.override(a base64 data URL) from the client but theprojecttable has no column for it, so the value is silently dropped. On restart, the server returns the project without the override and the icon reverts to the first-letter fallback.This PR adds an
icon_overridetext column and wires it throughfromRow,update, and thefromDirectoryupsert so the server persists and round-trips the value. Also normalizes the client-side dialog to sendundefinedinstead of an empty string when no custom icon is set.How did you verify your code works?
ALTER TABLE project ADD icon_override text— matches the single-column pattern used by existing migrations.icon.overridesurvives the round-trip through the DB instead of relying solely on local Tauri Store cache.Screenshots / recordings
N/A — logic-only change, no UI modifications.
Checklist