Repository navigation
Conversation
Use forward slashes for normalized watcher paths so Windows file updates match open tabs and cached files consistently. Also refresh the nearest loaded ancestor for add and unlink events inside unloaded directories.
Normalize backslashes in file search queries so Windows @mention lookups match forward-slash indexed paths. This keeps the watcher path fix from breaking the prompt mention autocomplete on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17780
Type of change
What does this PR do?
Watcher updates on Windows could miss open tabs and cached files because normalized paths kept backslashes while the app compared forward-slash paths. This change normalizes watcher paths to forward slashes and refreshes the nearest loaded ancestor directory for add and unlink events inside unloaded subdirectories.
How did you verify your code works?
Ran
bun test --preload ./happydom.ts ./src/context/file/path.test.ts ./src/context/file/watcher.test.tsinpackages/app.Screenshots / recordings
Not included. This is not a UI change.
Checklist