Repository navigation
⚠️ DEPRECATED - Feat: Add Interactive Tool Management Modal to TUI - #1767
Closed
spoons-and-mirrors wants to merge 2 commits into
Closed
spoons-and-mirrors wants to merge 2 commits into
spoons-and-mirrors wants to merge 2 commits into
Conversation
- Implement interactive tool dialog allowing users to toggle tools per agent during chat sessions. - Tools are fetched from server API, categorized by source (built-in/MCP), and support fuzzy search. - Tool overrides are session and agent-scoped and not persisted to state. - Filter out tools that should not be shown to users
…vice - Replace hardcoded `name !== "patch" && name !== "invalid"` logic with documented metadata - Add ToolService with TOOL_DEFAULTS object explaining why tools are disabled: * patch: Experimental/deprecated tool marked 'do not use' * invalid: Internal error handling tool - Enhance /app/tools API to include defaultEnabled field in response - Update TUI to use API-provided defaults instead of hardcoded logic - Add proper App.state() caching with 60s TTL for tool metadata - Maintain backward compatibility with deprecated IsToolDefaultEnabled() - Only show tools that are meant to be user-manageable This centralizes tool default management, makes it self-documenting, and follows established patterns for state management and caching.
Contributor
Author
|
deprecated and improved on by #1854 |
spoons-and-mirrors
changed the title
spoons-and-mirrors
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Toolsmodal to the TUI, allowing users to easily toggle tools on/off per agent during their session, accessible via<leader>oor/toolsThis feature provides users with fine-grained control over their AI assistant's capabilities while
maintaining a clean, intuitive interface that integrates seamlessly with the existing TUI experience.
Core Features
warningcolorImplementation Details
Architecture & Maintainability
The PR includes two logical commits. The second commit is not required for the feature to work but improves maintainability.
patchandinvalidtools)• Introduces ToolService with App.state() caching patterns
• Centralizes tool defaults in documented TOOL_DEFAULTS object
• Replaces hardcoded logic with API-driven approach
• Maintains backward compatibility