Repository navigation
fix(util): use 24-hour time format - #17037
Closed
olivierverdier wants to merge 1 commit into
Closed
olivierverdier wants to merge 1 commit into
olivierverdier wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
|
Can we revisit this PR? Sounds good. |
Author
|
Partly because of this, I switched now to https://pi.dev/ since
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #7208
Type of change
What does this PR do?
Locale.time()was in fact ignoring the locale and always displaying the time (for sessions at least?) in 12h format. I fixed it to use 24h format instead (for lack of better use of a locale). It also works better as an international default.How did you verify your code works?
The change is a single line addition to an existing function.
bun turbo typecheckpassed.Screenshots / recordings
Change is highlighed in red:
Checklist
If you do not follow this template your PR will be automatically rejected.