Repository navigation
fix(mcp): treat CallToolResult isError as tool failure - #16988
Closed
MaheshBhushan wants to merge 2 commits into
Closed
MaheshBhushan wants to merge 2 commits into
MaheshBhushan wants to merge 2 commits into
Conversation
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16969
Type of change
What does this PR do?
When an MCP tool returns
CallToolResultwithisError: true, this PR throws an error from the MCP tool execution path instead of returning it as a successful tool result.Before this change:
isError=trueresponses were returned through normal result flow.tool-resultand setstate.status = "completed".After this change:
isError=trueresponses are converted to thrown errors with extracted text.tool-errorpath.erroras expected.How did you verify your code works?
result.isError.Screenshots / recordings
Not included (logic change only).
Checklist