Repository navigation
fix(opencode): map apply_patch to edit permission - #16051
Closed
6crucified wants to merge 2 commits into
Closed
6crucified wants to merge 2 commits into
6crucified wants to merge 2 commits into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
|
@6crucified can you do another PR for us please? Hopefully, @allisoneer can upvote and I will upvote too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16028
Type of change
What does this PR do?
this fixes permission mapping for codex patch edits.
apply_patchwas not included in edit tool mapping, so configs like"*": "deny"with"edit": "allow"still blocked patch edits.i mapped
apply_patchtoeditin permission checks and legacy tools migration, and updated related tool-kind/filter handling so behavior is consistent.this works because all edit-style tools now resolve through the same
editpermission path.How did you verify your code works?
ran these tests locally in
packages/opencode:bun test test/permission/next.test.tsbun test test/agent/agent.test.tsbun test test/config/config.test.tsall passed.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
n/a
Checklist