Repository navigation
Conversation
The Gemini function calling API rejects schemas containing contentEncoding and contentMediaType keywords. The existing sanitizer strips properties/required from non-object types but missed these JSON Schema keywords. MCP servers like chrome-devtools-mcp use contentEncoding: "base64" in tool schemas, causing 400 errors when used with Gemini models.
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15408
Type of change
What does this PR do?
The Gemini function calling API rejects schemas containing
contentEncodingandcontentMediaType— valid JSON Schema keywords that Gemini does not support. The existingsanitizeGeminifunction (introduced in #3140) stripsproperties/requiredfrom non-object types but missed these two keywords.MCP servers like
chrome-devtools-mcpusecontentEncoding: "base64"in tool schemas (e.g.take_screenshot,upload_file), causing 400 errors when used with Gemini models.The fix adds two
deletecalls to the existing sanitizer to stripcontentEncodingandcontentMediaTypefrom all schema nodes before sending to Gemini.How did you verify your code works?
Added two test cases in
transform.test.tscovering direct and nested array scenarios. All 105 existing tests continue to pass.Screenshots / recordings
N/A — server-side schema change, no UI impact.
Checklist