Skip to content

fix: Add symlink setting (opt-in) to fix workflows relying on them#12992

Open
jeroenev wants to merge 3 commits intoanomalyco:devfrom
jeroenev:add_symlink_setting
Open

fix: Add symlink setting (opt-in) to fix workflows relying on them#12992
jeroenev wants to merge 3 commits intoanomalyco:devfrom
jeroenev:add_symlink_setting

Conversation

@jeroenev
Copy link
Copy Markdown

@jeroenev jeroenev commented Feb 10, 2026

What does this PR do?

This PR adds a setting to allow RG / Grep to follow symlinks, like it used to do.
A setting was added to make this behavior opt-in, to avoid issues with complex folder structures + symlinks

How did you verify your code works?

Ran the tests, and tested with codebases where modules are added via symlinks, which PR #11415 broke.
That PR disabled following symlinks in search tools, to fix performance issues from symlinks to large directories or symlink loops.
By doing so it breaks other workflows that rely on symlinks to add modules, so this setting fixes that.

Fixes #10365

@github-actions
Copy link
Copy Markdown
Contributor

Hey! Your PR title Add symlink setting doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@jeroenev jeroenev changed the title Add symlink setting fix: Add symlink setting (opt-in) to fix workflows relying on them Feb 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@jeroenev
Copy link
Copy Markdown
Author

jeroenev commented Feb 15, 2026

Note that this just adds a setting for reverting to the original behavior from 2 weeks ago, as it was changed in PR #11415

@jeroenev jeroenev force-pushed the add_symlink_setting branch from ebd0736 to 25c3b06 Compare February 18, 2026 07:59
@jeroenev
Copy link
Copy Markdown
Author

jeroenev commented Feb 18, 2026

rebased everything on top of dev
EDIT: rebased again 05-03-2026

@frostiio
Copy link
Copy Markdown

frostiio commented Mar 6, 2026

Am running version opencode 1.2.18 on Fedora. The @ does not detect the symlink in the workspace, but if I explicitly ask the agent "what do you see" in the folder symlink, it is able to list out the content in it.

@martijnvdbrug
Copy link
Copy Markdown

Nice work @jeroenev . Perhaps solve the merge conflict, so the anomaly team can merge this PR.

( I am not part of anomaly or anyhing, just like to have this fixed as well 🙃 )

@jeroenev jeroenev force-pushed the add_symlink_setting branch from 50fe8a4 to 4a9e31d Compare March 26, 2026 14:34
@jeroenev
Copy link
Copy Markdown
Author

jeroenev commented Mar 26, 2026

Rebased and fixed all conflicts, I hope this can get merged soon.
but yeah it can take a while until someone looks at this PR
they're probably getting overloaded 🙃
there are so many changes this PR gets conflicts every week, but I'm happy to keep rebasing until someone looks at it to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symlinked directories not visible in project picker (opencode serve)

3 participants