fix(opencode): support dynamic bash timeout via OPENCODE_BASH_TIMEOUT env var#12921
Open
Mr-Neutr0n wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): support dynamic bash timeout via OPENCODE_BASH_TIMEOUT env var#12921Mr-Neutr0n wants to merge 1 commit intoanomalyco:devfrom
Mr-Neutr0n wants to merge 1 commit intoanomalyco:devfrom
Conversation
… env var Change OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS from a static module-load-time constant to a dynamic getter so the env var is read at access time instead of import time. This allows the timeout to be changed at runtime without restarting the process. Closes anomalyco#12762
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
This PR would be very helpful for users with slower machines. I often work on low-spec hardware where compilation and command execution take longer than the default 2-minute timeout, causing builds and long-running commands to be cancelled prematurely. Having this environment variable working properly would allow us to adjust the timeout based on our hardware capabilities. Thanks for working on this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MSfrom a staticconst(evaluated once at module load) to a dynamic getter viaObject.defineProperty, so the env var is read at access timebash.tsto use agetDefaultTimeout()function instead of the staticDEFAULT_TIMEOUTconstantCloses #12762
Test plan
OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS=5000before launching opencode, verify bash commands time out after 5 seconds