Repository navigation
fix: separate ignore instances for .gitignore and .ignore - #12876
Closed
brandtcormorant wants to merge 3 commits into
Closed
brandtcormorant wants to merge 3 commits into
brandtcormorant wants to merge 3 commits into
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
brandtcormorant
changed the title
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4739
This fixes File.list() to process .gitignore and .ignore separately instead of merging them into a single ignore instance. This allows .ignore negation patterns (e.g. !/foo/) to override .gitignore rules, matching the intended behavior where .ignore controls what tools like the filepicker show independently of what git tracks.
My use case is to ignore git repos inside another git repo but still be able to traverse them in the filepicker.
An example of what this pull request enables:
.gitignore:
.ignore:
This is useful in a workspace that isn't a monorepo but that manages a set of repositories. There are probably other use cases for the changes in this pull request, things like having gitignored sandbox or tmp directories where we still want to easily reference the contents.
How did you verify your code works?
Ran tests to make sure nothing broke and launched using
bun dev path/to/project/where i had .gitignore and .ignore files set up like above.