Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Add ability for custom models to inherit metadata from models.dev using
the use_models_dev field with 'provider/model' format.
Changes:
- Extract mergeModel() helper with variadic merge function for cleaner
priority-based field resolution (explicit > inherited > existing > defaults)
- Add comprehensive tests for inheritance and invalid reference handling
Models can now inherit base properties from models.dev while overriding
specific fields:
{ use_models_dev: 'anthropic/claude-sonnet-4-20250514', limit: {...} }
Closes #9311
Author
|
Test failures are flakes in unrelated code. |
|
Why did you close the PR? |
Author
Because I don't want to maintain a PR up to date for an extended period with no response. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability for custom models to inherit metadata from models.dev using the use_models_dev field with 'provider/model' format.
Changes:
Models can now inherit base properties from models.dev while overriding specific fields:
{ use_models_dev: 'anthropic/claude-sonnet-4-20250514', limit: {...} }This address and fixes #9311
How did you verify your code works?
use_models_devand confirmed that inherited options (like variants, context size, etc) were respected despite not being explicitly defined.