Skip to content

feat(acp): expose subagents in available modes response - #12563

Closed
YichenLi00 wants to merge 1 commit into
anomalyco:devfrom
YichenLi00:feat/acp-expose-subagents
Closed

feat(acp): expose subagents in available modes response#12563
YichenLi00 wants to merge 1 commit into
anomalyco:devfrom
YichenLi00:feat/acp-expose-subagents

Conversation

@YichenLi00

@YichenLi00 YichenLi00 commented Feb 7, 2026

Copy link
Copy Markdown

Summary

Expose subagents in ACP available modes response for client-side access.

Closes #11576

Problem

ACP clients (e.g., agent-shell for Emacs) cannot access subagent information through ACP. Users need this to @mention specific subagents.

Solution

  • Add optional mode field to ModeOption type
  • Remove server-side subagent filter
  • Clients can filter by mode field if they only want primary agents

Changes

- type ModeOption = { id: string; name: string; description?: string }
+ type ModeOption = { id: string; name: string; description?: string; mode?: string }
- .filter((agent) => agent.mode !== "subagent" && !agent.hidden)
+ .filter((agent) => !agent.hidden)
  .map((agent) => ({
    id: agent.name,
    name: agent.name,
    description: agent.description,
+   mode: agent.mode,
  }))

Backward Compatibility

Existing clients continue to work. The mode field is optional and only adds information.

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@YichenLi00
YichenLi00 force-pushed the feat/acp-expose-subagents branch from 434c91f to e1feb5b Compare February 7, 2026 03:55
@YichenLi00
feat(acp): expose subagents in available modes response
e1feb5b 
- Add optional mode field to ModeOption type
- Remove subagent filter, let clients decide visibility
- Enables ACP clients to access subagent info for @mentions
@YichenLi00 YichenLi00 mentioned this pull request Feb 7, 2026
Closed
1 task done
@YichenLi00

YichenLi00 commented Feb 7, 2026

Copy link
Copy Markdown
Author

@rekram1-node Fixed the issues from #12305:

  1. Added mode field to ModeOption type
  2. Why expose subagents: ACP clients like Emacs agent-shell need this for @mentions. Server shouldn't decide visibility - clients can filter by mode field if needed.

@riccardogiorato

riccardogiorato commented Apr 3, 2026

Copy link
Copy Markdown

Any news on this ACP support @rekram1-node ?

@rekram1-node

rekram1-node commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Support subagent information in ACP

3 participants

@YichenLi00 @riccardogiorato @rekram1-node