Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12111
What does this PR do?
Please provide a description of the issue (if there is one), the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the pr.
Tool call arguments were not always very apparent in tool call approval requests through the TUI. This causes issues, as there are times when the arguments of the tool call are important for the context of if they should be approved or not.
While this information was sometimes provided in-line of the chat for primary agents, I found the subagent tool calls were completely blind in this regard. Also, it is a better UX if the user is able to see it presented in the approval selection UI.
Code is simple. Made an improved renderer for tool call args, truncating them if they are too long (or there are too many). On fullscreen, we do not do the truncation. Also added configuration values, as requested by the issue, to enable this globally or selectively on specific MCP tools.
How did you verify your code works?
Ran the TUI and tried MCP tool calls with various different datatypes. Ensured existing tool calls (e.g. read, write) were not impacted. Also verified all 3 new configuration states worked as expected.
Before (or with mcp_show_parameters==="none"):
After:
