Repository navigation
Conversation
…er match what's setup in microsoft's entra
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Added validation for resource URL and client authentication for Azure AD.
|
What are the chances that this will be merged?) |
| log.info("added client_id to token request", { mcpName: this.mcpName }) | ||
| } | ||
| // Remove resource parameter - Microsoft Entra ID v2.0 uses scope only | ||
| params.delete("resource") |
There was a problem hiding this comment.
This is not correct. Entra v2 endpoint supports resource parameters. We added it specifically to support mcp. Check the vscode implementation.
Failing to supply the resource parameter can lead to confused deputy attacks
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/entra/identity-platform/scopes-oidc?utm_source=chatgpt.com#using-the-default-scope-with-the-client
Even microsofts examples omit it, it's required in v1 flows but all the documentation i've read (and stuff we've done internally) omit it because it uses the SCOPE param to determine this
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
fixes #12308
Would fail before, now i have two entra auth secured MCP servers hooked up:
