Repository navigation
feat: add OPENCODE_RESPECT_LSP_DIAGNOSTICS flag to ensure LSP diagnostics are always processed - #12286
Closed
lmn451 wants to merge 1 commit into
Closed
feat: add OPENCODE_RESPECT_LSP_DIAGNOSTICS flag to ensure LSP diagnostics are always processed#12286lmn451 wants to merge 1 commit into
lmn451 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Author
|
Follow-up pushed: updated Current behavior:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENCODE_RESPECT_LSP_DIAGNOSTICShandling for LSP diagnostic flow.0(existing behavior; no timeout override mode).> 0enables the override mode and uses that value as the timeout in seconds.Behavior
OPENCODE_RESPECT_LSP_DIAGNOSTICS=0(or unset): existing behavior.OPENCODE_RESPECT_LSP_DIAGNOSTICS=<N>whereN > 0:NsecondsUsage
export OPENCODE_RESPECT_LSP_DIAGNOSTICS=10 opencodeIssue Addressed
Fixes #12288.
This follow-up update was made to satisfy the issue comment requesting numeric timeout semantics (value = seconds), where
3is only an example value.Testing
bun test test/lsp/client.test.ts(frompackages/opencode) passes.