Repository navigation
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
JtMotoX
changed the title
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
JtMotoX
marked this pull request as draft
February 3, 2026 07:19
Enhances the pattern matching functionality to support regex patterns for more complex use cases. - Implemented regex matching in Wildcard.match function - Added tests for regex patterns in wildcard tests - Updated documentation to include regex usage examples - Enhanced permission evaluation to handle regex patterns
JtMotoX
force-pushed
the
feature/regex-bash-permissions
branch
2 times, most recently
from
February 3, 2026 07:26
59d7a6c to
e4faa16
Compare
Clarified the explanation of regex patterns in the permissions documentation. - Removed examples of regex features for conciseness - Maintained focus on JavaScript regex evaluation
|
This would relieve my pain! 👍 |
|
Great job! |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11397
This adds regex pattern support to the permission system for more flexible pattern matching. Previously, the permission system only supported simple wildcards (* and ?). This enhancement allows users to define more complex patterns using regular expressions by wrapping them in forward slashes (e.g., "/pattern/").
The changes include:
Wildcard.matchfunction to detect and handle regex patterns (patterns starting and ending with "/")This allows users to write more precise permission rules, such as:
How did you verify your code works?
I copied all of my regex patterns from my vscode github copilot extension settings over to my opencode.json permissions. All my bash allow/ask/deny rules worked perfectly in opencode. I also tested the original wildcard rules and they still work.