Repository navigation
fix(tui): prevent crash when theme search returns no results - #10565
Merged
Merged
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potential duplicate: PR #8879 - fix(tui): prevent crash in theme dialog when filter yields no results This PR appears to be addressing the same issue - preventing crashes in the TUI theme dialog when filtering/searching returns no results. Both PRs deal with the same component (theme dialog) and the same problem (crash when no options match the search). You should verify if PR #8879 is still open or if this is a new attempt to fix the same issue. |
xenonwellz
pushed a commit
to xenonwellz/opencode
that referenced
this pull request
Jan 28, 2026
8 tasks
Colin4k1024
pushed a commit
to Colin4k1024/opencode
that referenced
this pull request
Feb 10, 2026
3 tasks
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10488
When searching for themes in the TUI that don't exist, the DialogSelect component would crash with
undefined is not an object (evaluating 'opt.value'). This happened because the onMove callback was being called even when the filtered options list was emptyBefore
After
The fix adds a safety check in the moveTo function to only call onMove when there's actually a valid option selected.
How did you verify your code works?
This is a minimal bug fix that follows the existing code patterns and doesn't change any external behavior.