Skip to content

fix: permission prompt should ignore keyboard events while dialog stack len > 0 - #10338

Merged
rekram1-node merged 1 commit into
anomalyco:devfrom
justfortheloveof:fix-permission-keyboard-event
Jan 24, 2026
Merged

rekram1-node merged 1 commit into
anomalyco:devfrom
justfortheloveof:fix-permission-keyboard-event

Conversation

@justfortheloveof

Copy link
Copy Markdown
Contributor

What does this PR do?

How did you verify your code works?

Manually tested all combinations of permission prompt being open, including the subagent rejection prompt, then opening the command palette, using keys that the permission prompts would react to, potentially changing settings or opening other dialogs such as the "connect a provider".

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@justfortheloveof
justfortheloveof force-pushed the fix-permission-keyboard-event branch from aa70ccd to 5c4dfbd Compare January 24, 2026 15:14
@rekram1-node
rekram1-node merged commit 077d17d into anomalyco:dev Jan 24, 2026
4 checks passed
@justfortheloveof
justfortheloveof deleted the fix-permission-keyboard-event branch January 24, 2026 20:07
xenonwellz pushed a commit to xenonwellz/opencode that referenced this pull request Jan 28, 2026
Colin4k1024 pushed a commit to Colin4k1024/opencode that referenced this pull request Feb 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
meSingh pushed a commit to meSingh/opencode that referenced this pull request Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission prompt intercept keyboard inputs when a dialog is open

2 participants