Repository navigation
fix(app): normalize path separators for session diff filtering on Windows - #10291
Merged
adamdotdevin merged 1 commit intoJan 23, 2026
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
alexyaroshuk
changed the title
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
xenonwellz
pushed a commit
to xenonwellz/opencode
that referenced
this pull request
Jan 28, 2026
3 tasks
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9921
What does this PR do?
Normalizes path separators when comparing file paths in the session diff filtering logic. On Windows, path.relative() returns paths with backslashes (), but Git always outputs paths with forward slashes (/). This mismatch caused modified files to be filtered out of the session review on Windows.
The fix:
Added .replaceAll("\", "/") to normalize Windows backslashes to forward slashes before comparing against Git's output.
How did you verify your code works?
On Windows, started a new session, tested modify file, delete file and create file operations.
Before
Opencode review cannot see some files have been changed
After
Fixed
