desktop: a timed-out shell env probe at launch leaves the whole session on the minimal PATH #62732

Activity

1. opencodejr commented on Nov 8, 2026

   

   opencodejrBot

   on Nov 8, 2026

   Contributor

   More actions

   Thanks for the detailed report. I reproduced this by running Desktop's shell-environment loader directly. I don't have macOS here, but the loader has no macOS-specific code path, and shell-env.ts is identical between v2.2.6 and the latest dev (caf8d6a55).

   Setup: a login profile that adds a Homebrew-like directory to PATH, plus an interactive rc that runs sleep 6, in a launchd-like environment (PATH=/usr/bin:/bin:/usr/sbin:/sbin).

   • bash -l on its own finishes quickly with the extra directory on PATH, so the -l fallback would have worked.
   • loadShellEnv logs [server] Interactive shell env probe timed out: /bin/bash and returns null without trying -l.
   • After the startup merge, process.env.PATH stays /usr/bin:/bin:/usr/sbin:/sbin. preferApplicationEnvironment runs only once at startup, so nothing probes again later in the session.

   The script below reproduces it. Related:

   • Desktop drops shell environment when interactive probe times out #49449: the same problem on v1, closed in the v1 cleanup rather than fixed
   • fix(desktop): retry shell env probe after timeout #49268: an unmerged v1 pull request that added the -l retry after a timeout
   • fix(desktop): stop blocking startup on the login shell probe #62667: an open pull request that makes the probe async but keeps the same timeout behaviour

   Reproduction script (repro.sh)

   #!/usr/bin/env bash
   # Reproduces anomalyco/opencode#62732 against the desktop shell-env code.
   # Usage: REPO=/path/to/opencode-checkout bash repro.sh
   # A fake HOME whose login profile adds a "Homebrew" dir to PATH, and whose
   # interactive rc takes 6 s (> the 5 s probe timeout), like a slow ~/.zshrc.
   set -euo pipefail
   REPO=${REPO:-/workspace/repo}
   H=$(mktemp -d)
   mkdir -p "$H/brew/bin"; printf '#!/bin/sh\necho gh fake\n' > "$H/brew/bin/gh"; chmod +x "$H/brew/bin/gh"
   cat > "$H/.bash_profile" <<P
   export PATH="$H/brew/bin:\$PATH"
   case \$- in *i*) . "$H/.bashrc";; esac
   P
   echo 'sleep 6' > "$H/.bashrc"
   cat > "$REPO/packages/desktop/repro-62732.ts" <<'T'
   import { NodePath } from "@effect/platform-node"
   import { Effect } from "effect"
   import { loadShellEnv } from "./src/main/service/shell-env"
   const t = Date.now()
   const env = await Effect.runPromise(
     loadShellEnv("/bin/bash").pipe(Effect.provide(NodePath.layer)) as any,
   )
   console.log(`loadShellEnv took ${Date.now() - t} ms, result:`, env === null ? "null" : `PATH=${(env as any).PATH}`)
   // what preferApplicationEnvironment then does: Object.assign(process.env, { ...shellEnv })
   Object.assign(process.env, { ...(env as any) })
   console.log("process.env.PATH after preferApplicationEnvironment-style merge:", process.env.PATH)
   T
   cd "$REPO/packages/desktop"
   echo "== bash -l alone (what the -l fallback would return):"
   env -i HOME="$H" PATH=/usr/bin:/bin:/usr/sbin:/sbin /bin/bash -l -c 'echo PATH=$PATH; command -v gh'
   echo "== loadShellEnv with a launchd-like minimal env:"
   env -i HOME="$H" SHELL=/bin/bash PATH=/usr/bin:/bin:/usr/sbin:/sbin "$(command -v bun)" repro-62732.ts
   rm -f repro-62732.ts

   Run it: bash repro.sh
2. opencodejr

   added

   reproduced

   on Nov 8, 2026
3. bunnysayzz commented on Nov 8, 2026

   

   bunnysayzz

   on Nov 8, 2026

   More actions

   Root cause: in packages/desktop/src/main/service/shell-env.ts, loadShellEnv returns null as soon as the -il probe times out. The -l fallback only runs when -il fails outright, never on a timeout, so a slow login shell at launch leaves the session on launchd's minimal PATH.

   Fix is up in #62736: on timeout, fall through to the -l probe. Added a regression test that fails on the old code and passes with the fix (bun test 4/4 in packages/desktop).