core: boundImages spends its image-budget cut on remote images that carry no payload #61391

Activity

1. opencodejr commented on Nov 3, 2026

   

   opencodejrBot

   on Nov 3, 2026

   Contributor

   More actions

   Thanks for the clear report. I reproduced this on the latest dev (3ba597f) with a unit test for boundImages, using two remote (Media.url) images followed by two 13 MiB inline images. The first three images were all replaced with the removal notice: both remote ones and c.png. Removing only c.png would have been enough, so the count was 3 instead of 1.

   The cause is in the cut loop: it moves past remote images even though they count 0 bytes toward the budget, so those slots free nothing. The script below reproduces it.

   Related: #53304 (keeping the removed set stable for the prompt cache, same function).

   Reproduction script (repro-61391.test.ts)

   import { expect, test } from "bun:test"
   import { Message, Media } from "@opencode/ai/effect"
   import { boundImages } from "@opencode/core/session/model-request"
   
   // #61391: remote (url) images carry no inline payload, yet boundImages spends cut slots on them.
   const remote = (name: string) =>
     Message.user({ type: "media", media: Media.url(`https://example.com/${name}`, { mediaType: "image/png" }), filename: name })
   const inline = (name: string) =>
     Message.user({ type: "media", media: Media.base64("a".repeat(13 * 1024 * 1024), "image/png"), filename: name })
   const removed = (messages: ReturnType<typeof boundImages>) =>
     messages.filter((message) => message.content[0]?.type === "text").length
   
   test("spends the image budget only on images with a payload", () => {
     const result = boundImages([remote("a.png"), remote("b.png"), inline("c.png"), inline("d.png")])
     console.log("replaced:", result.map((m, i) => `${["a", "b", "c", "d"][i]}=${m.content[0]?.type}`).join(" "))
     expect(removed(result)).toBe(1)
   })

   Run it: bun repro-61391.test.ts
2. opencodejr

   added

   reproduced

   on Nov 3, 2026
3. jimmyallinai commented on Nov 3, 2026

   

   jimmyallinai

   on Nov 3, 2026

   Contributor

   More actions

   I'll take this one. The bot's reproduction matches the report: boundImages spends cut slots on remote/ref images that carry 0 bytes, so two free images plus one inline image get replaced where only the inline one should be.

   Plan: reproduce first with the boundImages unit case (2 remote + 2 x 13 MiB inline, expect 1 removed), then fix the cut loop to skip zero-byte media when choosing what to remove, and run the neighbouring session-model-request tests plus the package typecheck before opening a PR.