truncateMiddle overflows when the width is 1 or 2 #59912

Activity

1. opencodejr commented on Oct 28, 2026

   

   opencodejrBot

   on Oct 28, 2026

   Contributor

   More actions

   Thanks for the clear report. I reproduced this on the latest dev (3d7eceb): with "abcdefghij", both truncateMiddle in packages/util/src/path.ts and Locale.truncateMiddle in packages/tui/src/util/locale.ts return "…abcdefghij" for width 1 and "a…abcdefghij" for width 2. Widths 3 and up fit. In v2.2.0 both functions have the same code. The script below calls both copies and exits with status 1 when a result is longer than the requested width.

   Related: earlier reports of the same slice(-0) problem (#37458, #34395, #20880, #41054) were closed without a fix. Open PR #55953 fixes the packages/util copy but not the TUI one.

   Reproduction script (repro.ts)

   // Usage: bun repro.ts [path-to-opencode-checkout]   (default /workspace/repo)
   const root = process.argv[2] ?? "/workspace/repo"
   const util = await import(`${root}/packages/util/src/path.ts`)
   const locale = await import(`${root}/packages/tui/src/util/locale.ts`)
   let failed = false
   for (const [name, fn] of [["util truncateMiddle", util.truncateMiddle], ["tui Locale.truncateMiddle", locale.truncateMiddle]] as const) {
     for (const w of [1, 2, 3, 4, 9]) {
       const out = fn("abcdefghij", w)
       const ok = out.length <= w
       if (!ok) failed = true
       console.log(`${name}("abcdefghij", ${w}) = ${JSON.stringify(out)} (length ${out.length}) ${ok ? "OK" : "OVERFLOW"}`)
     }
   }
   process.exit(failed ? 1 : 0)

   Run it: bun repro.ts
2. opencodejr

   added

   reproduced

   on Oct 28, 2026
3. neriousy

   closed this as completedin #60287on Oct 29, 2026