tui: cursor.style block crashes in cursorStyle (e.color undefined) #58992

Activity

1. opencode-agent commented on Oct 25, 2026

   

   opencode-agentBot

   on Oct 25, 2026 – with OpenCode Agent

   Contributor

   More actions

   Thanks for the detailed report! I reproduced this crash on 2.1.4, with the same undefined is not an object (evaluating 'e.color') error and the same stack. It still happens on the latest dev (15646867).

   In my tests, block itself is not the trigger. The crash happens when a hot reload changes cursor from set to unset. Steps:

   1. Start the TUI with "cursor": { "style": "block", "blinking": true } in cli.json.
   2. Remove the cursor block from cli.json while the TUI is running.
   3. The TUI crashes as soon as the reload is applied.

   Switching from line to block, or starting with a block cursor or with no cursor setting at all, did not crash for me. The TUI passes the unset setting straight to the input's cursor style, and the code there doesn't handle a missing value.

   My guess for your case: an editor save may have left cli.json briefly incomplete or invalid. The TUI then drops the whole config on reload (see #56318), so cursor is unset for that moment. I haven't confirmed this.

   Until it is fixed, avoid changing or removing the cursor setting while the TUI is running. Restart after editing it instead.

   The recording and screenshot below show the crash, and the script below reproduces it.

   Related: #56318 (one invalid cli.json field discards the whole config), #43521 (cursor style ignored in --mini).

   recording.mp4

   

   Reproduction script (drive.ts)

   // Repro for #58992: with a `cursor` block in cli.json, a hot reload that changes/removes it
   // while a dialog with a text input (e.g. the ctrl+p command palette) is open crashes the TUI
   // in the @opentui `cursorStyle` setter (`undefined is not an object (evaluating 'e.color')`).
   import { Effect } from "effect"
   import { OpenCodeDriver } from "opencode-drive"
   import { readFileSync, writeFileSync } from "node:fs"
   import { join } from "node:path"
   
   const text = (f: any) => f.lines.map((l: any) => l.spans.map((s: any) => s.text).join("")).join("\n")
   
   export default OpenCodeDriver.use(
     {
       ...(process.env.OC_DEV ? { opencode: { dev: process.env.OC_DEV } } : {}),
       tui: { recording: true },
       tuiConfig: { cursor: { style: "block", blinking: true } },
     } as any,
     ({ ui, artifacts }) =>
       Effect.gen(function* () {
         const cfg = join(artifacts, "files", ".opencode", "cli.json")
         yield* Effect.sleep("3 seconds")
         yield* ui.press("p", { ctrl: true })
         yield* Effect.sleep("2 seconds")
         yield* ui.screenshot("palette-open")
         const json = JSON.parse(readFileSync(cfg, "utf8"))
         delete json.cursor
         writeFileSync(cfg, JSON.stringify(json, null, 2))
         yield* Effect.log("cli.json now: " + readFileSync(cfg, "utf8"))
         yield* Effect.sleep("5 seconds")
         yield* ui.screenshot("after-reload")
         yield* Effect.log(text(yield* ui.capture()))
       }),
   )

   Run it with opencode-drive: opencode-drive run ./drive.ts. It drives opencode from your PATH; set OC_DEV to the path of an OpenCode checkout to run that from source instead.
2. opencode-agent

   added

   reproduced

   on Oct 25, 2026
3. tneemo commented on Oct 26, 2026

   

   tneemo

   on Oct 26, 2026

   More actions

   I'd like to take this one. The crash comes from resolve() returning cursor: undefined after a reload, which the inputs then pass straight to OpenTUI's cursorStyle setter. I have a fix that resolves an unset cursor to OpenTUI's default (block, blinking) and makes mounted inputs pick up the reloaded value, plus a regression test that mounts DialogPrompt and reproduces the same stack. I can open the PR if that works for you.
4. neriousy

   closed this as completedin #60302on Oct 29, 2026