desktop: maximized state lost when saved bounds exceed the display #58247

Activity

1. opencode-agent commented on Oct 22, 2026

   

   opencode-agentBot

   on Oct 22, 2026 – with OpenCode Agent

   Contributor

   More actions

   Thanks for the detailed report and the analysis. I could reproduce this with the window-state logic from v2.1.3, and it still happens on the latest dev (d93568f). I didn't run the desktop app itself here. Instead I ran the real window-state.ts with a stubbed window on a single 1388×781 display.

   What I saw:

   1. On a fresh profile, the window first maps unmaximized at the size from your report (x: 2, y: 34, 1284×783). It's then maximized and the app quits. The saved file has isMaximized: true along with those bounds, which are taller than the display (34 + 783 > 781).
   2. On every later launch, resolveWindowState() rejects the state and returns the 1280×800 fallback at 0,0 with no isMaximized, so the window never reopens maximized.
   3. Quitting while maximized writes the same oversized bounds back, so this repeats on every launch.
   4. Your exact saved state resolves to the same fallback, with isMaximized dropped.

   The code's own comment says a saved maximized or fullscreen state should be kept, so this looks like a bug, not intended behaviour. The fallback's 1280×800 size doesn't fit a 781px-tall display either.

   The script below reproduces it. Run it as REPO=<opencode checkout> ./repro.sh <git-ref>.

   Related: #56970 (window position and size not remembered on Windows) and PR #57088 (adds a tolerance to the bounds check and keeps the maximized/fullscreen flags only when the state file is invalid, so it doesn't cover this case).

   Reproduction script (repro.sh)

   #!/usr/bin/env bash
   # Usage: repro.sh <git-ref>   (run with REPO=/path/to/opencode checkout)
   set -euo pipefail
   REPO=${REPO:-/workspace/repo}; REF=${1:-v2.1.3}
   D=$(mktemp -d)
   git -C "$REPO" show "$REF:packages/desktop/src/main/windows/window-state.ts" > "$D/window-state.ts"
   cat > "$D/run.ts" <<'TS'
   import { resolveWindowState, manageWindowState } from "./window-state"
   import { readFileSync } from "node:fs"
   import { EventEmitter } from "node:events"
   const display = { x: 0, y: 0, width: 1388, height: 781 } // 1366x768 at scale 0.984375
   const displays = { all: () => [display], primary: () => display, matching: () => display }
   const defaults = { width: 1280, height: 800 }
   // Fake BrowserWindow: launched at defaults, user maximizes, then quits.
   function session(initial: any, file: string) {
     const w: any = new EventEmitter()
     let max = false, bounds = { x: initial.x ?? 0, y: initial.y ?? 0, width: initial.width, height: initial.height }
     Object.assign(w, { isDestroyed: () => false, getBounds: () => (max ? display : bounds), isMaximized: () => max,
       isMinimized: () => false, isFullScreen: () => false, maximize: () => { max = true }, setFullScreen() {} })
     manageWindowState(w, file, initial, displays)
     const startedMaximized = max
     if (!max) {
       // Window maps in normal state; xfwm4 places it below the panel (as in the report): y=34, height 783
       bounds = { x: 2, y: 34, width: 1284, height: 783 }
       w.emit("close") // runs update() once in normal state (same as a debounced move/resize event)
     }
     max = true          // user maximizes
     w.emit("close"); w.emit("closed")
     return startedMaximized
   }
   const file = `/tmp/opencode/ws-${process.pid}.json`
   let saved: unknown = undefined
   for (let launch = 1; launch <= 3; launch++) {
     const initial = resolveWindowState(saved, defaults, displays)
     const restored = session(initial, file)
     saved = JSON.parse(readFileSync(file, "utf8"))
     console.log(`launch ${launch}: resolved=${JSON.stringify(initial)} -> opened maximized: ${restored}; saved on quit=${JSON.stringify(saved)}`)
   }
   // Reporter's exact saved state
   const r = resolveWindowState({"width":1284,"height":783,"x":2,"y":34,"displayBounds":display,"isMaximized":true,"isFullScreen":false}, defaults, displays)
   console.log("reporter state resolves to:", JSON.stringify(r), "isMaximized kept:", r.isMaximized === true)
   TS
   cd "$D" && bun run.ts

   Run it: bash repro.sh
2. opencode-agent

   added

   reproduced

   on Oct 22, 2026
3. tneemo commented on Oct 23, 2026

   

   tneemo

   on Oct 23, 2026

   More actions

   I'd like to take this one. The fallback in resolveWindowState drops isMaximized/isFullScreen when the saved bounds don't fit the display. I have a fix with regression tests ready and will open a PR shortly.
4. Hona

   closed this as completedin #60482on Oct 30, 2026