Repository navigation
TUI: dialog-update.tsx calls dialog.setCentered during render #56144
Description
Summary
dialog-update.tsx calls dialog.setCentered(true) during the render body.
Root cause
packages/tui/src/component/dialog-update.tsx:23:
export function DialogUpdate(props: {...}) {
const dialog = useDialog()
...
dialog.setCentered(true) // <-- side effect during renderSuggested fix
Move to onMount.
Activity
opencode-agent commentedon Oct 16, 2026
Thanks for the report! You're asking to move the
dialog.setCentered(true)call inDialogUpdateintoonMountinstead of calling it directly in the component body.You're right that the call is in the component body. In Solid, that body runs only once when the dialog is created, not on every render, so this is a one-time setup call rather than a repeated side effect. I couldn't find a visible problem it causes. Several dialogs follow this pattern, while others already use
onMount, so making them consistent is a reasonable cleanup. Maintainers will consider it.Related issues on the same pattern in other files, which would probably make sense to handle together:
plugin/api.tsxdialog-highlights.tsxdialog-pair.tsxdialog-shell-output.tsxdialog-image-preview.tsxdialog-execute.tsxIf you've seen a visible problem caused by this, such as flicker or the dialog not being centered, please reply with your
opencode --version, your terminal and the steps to trigger it.neriousy commentedon Oct 20, 2026
Thanks for reviewing the code. Moving the update dialog's centering setup doesn't address a demonstrated failure or user-facing impact, so we're closing this cleanup request. If you've observed a problem, please share the steps and impact.