Repository navigation
TUI: dialog-shell-output.tsx calls dialog.setSize/setCentered during render #56141
Closed as not planned
Description
Summary
dialog-shell-output.tsx calls dialog.setSize("xlarge") and dialog.setCentered(true) during the render body.
Root cause
packages/tui/src/component/dialog-shell-output.tsx:26-27:
export function DialogShellOutput(props: { shell: ShellInfo; location: LocationRef }) {
const dialog = useDialog()
...
dialog.setSize("xlarge")
dialog.setCentered(true) // <-- side effect during renderSuggested fix
Move to onMount.
Activity
opencode-agent commentedon Oct 16, 2026
Thanks for the report! I checked
dev:DialogShellOutputdoes calldialog.setSize("xlarge")anddialog.setCentered(true)in its component body. In Solid, though, a component body runs only once (it is not re-run on every render the way React's is), and both methods just set a value in the dialog store. Many other dialogs use the same pattern, so on its own this doesn't look like it causes a bug.Could you tell us, briefly and in your own words, whether you have seen an actual problem caused by this? For example:
opencode --version, OS and terminalYou can reply here with the details or edit the issue. If you edit it, please also leave a comment saying you've updated it so we know you're done.
Related issues you opened about the same pattern in other files (each covers a different file, so these are related, not duplicates; ordered by how closely they match):
dialog-image-preview.tsxsetSize/setCentered during renderdialog-execute.tsxsetSize/setCentered during renderdialog-pair.tsxsetSize/setCentered during renderplugin/api.tsxsetSize/setCentered during renderdialog-update.tsx/dialog-highlights.tsxsetCentered during renderdialog-skill.tsx/dialog-debug.tsxsetSize during renderdialog-prompt.tsxgotoLineEnd during renderIf this is purely about code style with no visible symptom, a single issue or PR covering all of these files would be easier for maintainers to review than one issue per file.
Addin commentedon Oct 16, 2026
Source code review finding. packages/tui/src/component/dialog-shell-output.tsx:26-27 calls dialog.setSize(xlarge) and dialog.setCentered(true) in the component body. Other dialogs use onMount for this (dialog-session-list.tsx:194, dialog-integration.tsx:518). No visible problem observed today, but it's a consistency issue worth addressing together with the related rendering issues (#56136-#56139, #56140, #56142-#56145).
opencode-agent commentedon Oct 16, 2026
Thanks for confirming! Since nothing visibly goes wrong, I'll treat this as a code-consistency improvement rather than a bug: move
dialog.setSize("xlarge")/dialog.setCentered(true)indialog-shell-output.tsxintoonMount, asdialog-session-list.tsxanddialog-integration.tsxalready do. Maintainers will consider it.The same pattern appears in the files from your related issues, so they would probably be easiest to review as a single cleanup rather than one change per file:
dialog-image-preview,dialog-execute,dialog-pair,plugin/api.tsxdialog-update,dialog-highlightsdialog-skill,dialog-debuggotoLineEndindialog-promptneriousy commentedon Oct 20, 2026
Thanks for reviewing the code. You confirmed that no visible problem occurs in the shell-output dialog, so we're closing this consistency request. If you encounter an actual failure, please share the steps and impact.