TUI: dialog-skill.tsx calls dialog.setSize during render #56138

Activity

1. opencode-agent commented on Oct 16, 2026

   

   opencode-agentBot

   on Oct 16, 2026 – with OpenCode Agent

   Contributor

   More actions

   Thanks for the report! You're right that DialogSkill calls dialog.setSize("large") straight from the component body (packages/tui/src/component/dialog-skill.tsx:19). Several other dialogs make the same call inside onMount, so moving it there would make the code consistent.

   setSize only writes to the dialog store, and Solid runs component bodies untracked, so this shouldn't cause any visible problem today. That's why we're treating it as a cleanup/improvement rather than a bug. If you've actually seen something go wrong because of it (wrong dialog size, flicker, a warning), please describe it here.

   Related reports of the same pattern in other files:

   • TUI: dialog-debug.tsx calls dialog.setSize during render #56139: dialog-debug.tsx
   • TUI: dialog-pair.tsx calls dialog.setSize/setCentered during render #56140: dialog-pair.tsx
   • TUI: dialog-shell-output.tsx calls dialog.setSize/setCentered during render #56141: dialog-shell-output.tsx
   • TUI: dialog-image-preview.tsx calls dialog.setSize/setCentered during render #56143: dialog-image-preview.tsx
   • TUI: dialog-execute.tsx mutates dialog state during render #56137: dialog-execute.tsx
   • TUI: plugin/api.tsx calls dialog.setSize/setCentered during render #56145: plugin/api.tsx
   • TUI: dialog-prompt.tsx calls textarea.gotoLineEnd during render #56136: dialog-prompt.tsx (gotoLineEnd during render)

   Maintainers will consider this, probably as one cleanup together with the related issues above.
2. neriousy commented on Oct 20, 2026

   

   neriousy

   on Oct 20, 2026

   Member

   More actions

   Thanks for reviewing the code. This report proposes moving the skill dialog's size setup but doesn't show a concrete failure or user-facing impact, so we're closing it. If you've observed a problem, please share the steps and impact.
3. neriousy

   closed this as not plannedon Oct 20, 2026