config: partial V1 capability overrides reset unspecified catalog capabilities #53280

Activity

1. github-actions

   assigned

   nexxeln

   on Oct 5, 2026
2. opencodejr commented on Oct 27, 2026

   

   opencodejrBot

   on Oct 27, 2026

   Contributor

   More actions

   Thanks for the detailed report and the patch. I can reproduce this on the latest dev (f930aa8a).

   I seeded the catalog model custom/chat with { tools: false, input: ["audio"], output: ["audio"] }, normalized a legacy provider.custom.models.chat override and applied it through ConfigProviderPlugin. Each partial override reset the fields it didn't set to the global defaults:

   • modalities.input: ["text","image"] → { tools: true, input: ["text","image"], output: ["text"] }
   • modalities.output: ["text"] → tools and input reset to true / ["text","image"]
   • tool_call: true → input and output reset to ["text","image"] / ["text"]
   • modalities.input: [] → tools: true, output: ["text"]

   The cause looks like migrateModel in packages/core/src/v1/config/migrate.ts, which fills omitted capability fields with Model.Capabilities.default() before Model.mergeCapabilities can fall back to the catalog values. The test file below reproduces it; place it in packages/core/test/config/ to run it.

   Reproduction script (repro-53280.test.ts)

   import { describe, expect } from "bun:test"
   import { Document, Info, type Entry } from "@opencode/schema/config"
   import { Effect, Schema } from "effect"
   import { Config } from "@opencode/core/config"
   import { ConfigProviderPlugin } from "@opencode/core/config/plugin/provider"
   import { ConfigNormalize } from "@opencode/core/config/normalize"
   import { Model } from "@opencode/core/model"
   import { Plugin } from "@opencode/core/plugin"
   import { PluginHost } from "@opencode/core/plugin/host"
   import { Provider } from "@opencode/core/provider"
   import { testEffect } from "../lib/effect"
   import { PluginTestLayer } from "../plugin/fixture"
   
   // Repro for anomalyco/opencode#53280: partial legacy capability overrides reset catalog capabilities.
   const it = testEffect(PluginTestLayer)
   const decode = Schema.decodeUnknownSync(Info)
   const addPlugin = Effect.fn(function* (entries: Entry[]) {
     const host = yield* PluginHost.make(yield* Plugin.Service)
     yield* ConfigProviderPlugin.Plugin.effect(host).pipe(Effect.provide(Config.testLayer(entries)))
   })
   
   const catalog = { tools: false, input: ["audio"], output: ["audio"] }
   describe("#53280", () => {
     for (const [name, legacy, expected] of [
       ["input-only", { modalities: { input: ["text", "image"] } }, { ...catalog, input: ["text", "image"] }],
       ["output-only", { modalities: { output: ["text"] } }, { ...catalog, output: ["text"] }],
       ["tool_call-only", { tool_call: true }, { ...catalog, tools: true }],
       ["empty input", { modalities: { input: [] } }, { ...catalog, input: [] }],
     ] as const) {
       it.effect(`legacy ${name} override keeps other catalog capabilities`, () =>
         Effect.gen(function* () {
           const providers = yield* Provider.Service
           const models = yield* Model.Service
           const providerID = Provider.ID.make("custom")
           const modelID = Model.ID.make("chat")
           yield* providers.transform((editor) => {
             editor.models.update(providerID, modelID, (model) => {
               model.capabilities = { tools: false, input: ["audio"], output: ["audio"] }
             })
           })
           const result = ConfigNormalize.normalize({ provider: { custom: { models: { chat: legacy } } } })
           if (result.type !== "normalized") throw new Error("Expected normalized config")
           yield* addPlugin([new Document({ type: "document", info: decode(result.encoded) })])
           const caps = (yield* models.get(providerID, modelID))?.capabilities
           console.log(name, JSON.stringify(caps))
           expect(caps).toMatchObject(expected)
         }),
       )
     }
   })

   Run it: bun repro-53280.test.ts
3. opencodejr

   added

   reproduced

   on Oct 27, 2026
4. Tarquinen

   closed this as completedin #62573on Nov 10, 2026